[webkit-reviews] review requested: [Bug 87635] Web Inspector: Add InspectorFileSystemAgent::FrontendProvider : [Attachment 144307] Patch

[bugzilla-daemon at webkit.org]

Taiju Tsuiki <tzik at chromium.org> has asked  for review:
Bug 87635: Web Inspector: Add InspectorFileSystemAgent::FrontendProvider
https://bugs.webkit.org/show_bug.cgi?id=87635

Attachment 144307: Patch
https://bugs.webkit.org/attachment.cgi?id=144307&action=review

------- Additional Comments from Taiju Tsuiki <tzik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144307&action=review


>> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:54
>> +	InspectorFrontend::FileSystem* getFrontend() const
> 
> style nit: we don't use get prefixes in WebKit, simply frontend()

Done

>> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:102
>> +	    m_frontendProvider->enable();
> 
> You could store a pointer to the agent itself, that way you wouldn't need to
propagate enable/disable calls to the FrontendProvider, the getFrontend()
method would look like
> 
> if (m_agent && m_agent->m_enabled)
>      return m_agent->mfrontend;
> return 0;

Done

Looks cleaner. Thanks!