[webkit-reviews] review denied: [Bug 85864] [Shadow] TITLE elements in Shadow DOM should not affect document.title attribute : [Attachment 144013] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 27 17:19:00 PDT 2012


Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 85864: [Shadow] TITLE elements in Shadow DOM should not affect
document.title attribute
https://bugs.webkit.org/show_bug.cgi?id=85864

Attachment 144013: Patch
https://bugs.webkit.org/attachment.cgi?id=144013&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
The test is really cryptic. It also can be more comprehensive.
We can test against a document which has a title
- to add newly created <title> to the shadow root
- to remove it
- to add subtree which contains <title> to the shadow root
- to remove it
- to add a subtree which has a shadow root, which has a <title> as a child (I
guess this case doesn't work)
- to remove it.


More information about the webkit-reviews mailing list