[webkit-reviews] review granted: [Bug 87591] Display cues in the controls area : [Attachment 144234] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Victor Carbune
<victor at rosedu.org>'s request for review:
Bug 87591: Display cues in the controls area
https://bugs.webkit.org/show_bug.cgi?id=87591

Attachment 144234: Patch
https://bugs.webkit.org/attachment.cgi?id=144234&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144234&action=review


The WebCore changes look fine, but please consider the comments about the test.


> LayoutTests/ChangeLog:8
> +	   * media/video-controls-rendering-toggle-display-none.html:

Is this test necessary now that we don't control visibility with "display"
style?	If the test is necessary, it seems that at least the test name and some
of the contents (comments, text logged) should be updated.

> LayoutTests/media/video-controls-rendering-toggle-display-none.html:40
>	       // Ensure paint with display property set to "none".

Is this comment incorrect now?