[webkit-reviews] review granted: [Bug 87566] [BlackBerry] Add a constructor to create a Path from an SkPath : [Attachment 144229] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 27 06:31:14 PDT 2012
Antonio Gomes <tonikitoo at webkit.org> has granted Arvid Nilsson
<anilsson at rim.com>'s request for review:
Bug 87566: [BlackBerry] Add a constructor to create a Path from an SkPath
https://bugs.webkit.org/show_bug.cgi?id=87566
Attachment 144229: Patch
https://bugs.webkit.org/attachment.cgi?id=144229&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144229&action=review
r+, but lets fix one think before landing: when reuploading, please pre-fill
"Reviewed by Antonio Gomes" and just set cq?
> Source/WebCore/platform/graphics/Path.h:162
> +#if PLATFORM(BLACKBERRY) && USE(SKIA)
I would drop the use(skia) here.
More information about the webkit-reviews
mailing list