[webkit-reviews] review granted: [Bug 35377] Changing the src attribute of an img element does not cancel the image load : [Attachment 144102] Cancel loads in CachedResource::allClientsRemoved.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 35377: Changing the src attribute of an img element does not cancel the
image load
https://bugs.webkit.org/show_bug.cgi?id=35377

Attachment 144102: Cancel loads in CachedResource::allClientsRemoved.
https://bugs.webkit.org/attachment.cgi?id=144102&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
In cases like this, where we want to be sure that derived classes call through
to the base class, it can be useful to have a debug assertion that fires if
someone forgets to do that.

If we know there is only one call site for a particular virtual function, we
can set up a global pointer to double check that we call all the way through to
the base class’s implementation exactly once. We should consider creating a
debug macro to help deploy this kind of checking for cases like this one.