[webkit-reviews] review granted: [Bug 87582] When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called : [Attachment 144208] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 26 16:55:41 PDT 2012


Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 87582: When pages are loaded from AppCache with DeferredLoading,
willSendRequest() is never called
https://bugs.webkit.org/show_bug.cgi?id=87582

Attachment 144208: Patch
https://bugs.webkit.org/attachment.cgi?id=144208&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144208&action=review


> Source/WebCore/loader/MainResourceLoader.cpp:701
> +	   ResourceRequest r(m_initialRequest);
> +	   m_initialRequest = ResourceRequest();
> +	   loadNow(r);

As long as you’re touching this code, it might be nice to use a word or words
for the name rather than just a letter. I’d suggest initialRequest or request
or localCopyOfRequest.


More information about the webkit-reviews mailing list