[webkit-reviews] review granted: [Bug 15495] SVGViewSpec DOM bindings aka SVGSVGElement.currentView is unimplemented : [Attachment 144200] Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 26 14:10:05 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 15495: SVGViewSpec DOM bindings aka SVGSVGElement.currentView is
unimplemented
https://bugs.webkit.org/show_bug.cgi?id=15495

Attachment 144200: Patch v3
https://bugs.webkit.org/attachment.cgi?id=144200&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144200&action=review


Looks good.

> LayoutTests/platform/mac/svg/custom/linking-a-03-b-all-expected.txt:23
>	 RenderSVGRect {rect} at (0,0) size 480x360 [stroke={[type=SOLID]
[color=#000000]}] [x=1.00] [y=1.00] [width=478.00] [height=358.00]

I wonder, can this test be made a reftest? Would save some rebaselining. I
leave it up to you if you want to do that before landing this patch, assuming
it is possible at all.


More information about the webkit-reviews mailing list