[webkit-reviews] review granted: [Bug 15799] textPath element does not re-render when referenced path changes : [Attachment 144093] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 23:16:44 PDT 2012


Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 15799: textPath element does not re-render when referenced path changes
https://bugs.webkit.org/show_bug.cgi?id=15799

Attachment 144093: Patch
https://bugs.webkit.org/attachment.cgi?id=144093&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144093&action=review


r=me! Great work!

> Source/WebCore/ChangeLog:9
> +	   Support textPath updating to changes on the referenced path. To make
this possible
> +	   refactor the event listener logic from SVGTRefElement into
SubtreeModificationEventListener.

Heh the ChangeLog is still wrong.

> LayoutTests/svg/custom/textPath-change-id.svg:8
> +	 layoutTestController.dumpAsText(true);

I don't think you need dumpAsText(true) for ref tests - you can omit this line
everywhere. ref tests always compare pixels as well.


More information about the webkit-reviews mailing list