[webkit-reviews] review denied: [Bug 64201] Composited fixed position layers have an incorrect overlap map entry : [Attachment 144173] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Adrienne Walker
<enne at google.com>'s request for review:
Bug 64201: Composited fixed position layers have an incorrect overlap map entry
https://bugs.webkit.org/show_bug.cgi?id=64201

Attachment 144173: Patch
https://bugs.webkit.org/attachment.cgi?id=144173&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144173&action=review


> Source/WebCore/rendering/RenderGeometryMap.cpp:150
> -	       inFixed &= currStep->m_isFixedPosition;
> +	       inFixed = currStep->m_isFixedPosition;

I still don't think this is right. This should be identical to
RenderBox::mapLocalToContainer(). It's:

if (we have a transform)
  if (this layer is fixed)
    treat as fixed
  otherwise
    transform turns off fixed positioning.

This is the part of the css transforms spec that says "transformed act as
contains for fixed position".

A testcase would have a position:fixed inside a transformed element.