[webkit-reviews] review granted: [Bug 86528] implement new negative flexing algorithm : [Attachment 144161] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 86528: implement new negative flexing algorithm
https://bugs.webkit.org/show_bug.cgi?id=86528

Attachment 144161: Patch
https://bugs.webkit.org/attachment.cgi?id=144161&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144161&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:876
> +	       if (availableFreeSpace > 0 && totalPositiveFlexibility > 0 &&
flexSign == PositiveFlexibility && isfinite(totalPositiveFlexibility))
>		   childSize += lroundf(availableFreeSpace *
child->style()->positiveFlex() / totalPositiveFlexibility);
> -	       else if (availableFreeSpace < 0 && totalNegativeFlexibility > 0 
&& flexSign == NegativeFlexibility)
> -		   childSize += lroundf(availableFreeSpace *
child->style()->negativeFlex() / totalNegativeFlexibility);
> +	       else if (availableFreeSpace < 0 &&
totalWeightedNegativeFlexibility > 0 && flexSign == NegativeFlexibility &&
isfinite(totalWeightedNegativeFlexibility))

Might want to mention this isfinite check in the ChangeLog description.