[webkit-reviews] review granted: [Bug 87454] createContextualFragment and insertAdjacentHTML should throw syntax error : [Attachment 144143] Address comments while waiting for a review

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 87454: createContextualFragment and insertAdjacentHTML should throw syntax
error
https://bugs.webkit.org/show_bug.cgi?id=87454

Attachment 144143: Address comments while waiting for a review
https://bugs.webkit.org/attachment.cgi?id=144143&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144143&action=review


> Source/WebCore/editing/markup.cpp:1055
> +PassRefPtr<DocumentFragment> createContextualFragment(const String& markup,
HTMLElement* htmlElement, FragmentScriptingPermission scriptingPermission,
ExceptionCode& ec)

I don’t think we should rename the element argument even though we are changing
the type.