[webkit-reviews] review denied: [Bug 87510] [chromium] create WebTransformOperation interface for chromium platform : [Attachment 144123] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied vollick at chromium.org's request
for review:
Bug 87510: [chromium] create WebTransformOperation interface for chromium
platform
https://bugs.webkit.org/show_bug.cgi?id=87510

Attachment 144123: Patch
https://bugs.webkit.org/attachment.cgi?id=144123&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144123&action=review


Needs a touch more indirection but the API looks quite nice.

> Source/Platform/chromium/public/WebTransformOperations.h:30
> +#include <wtf/Vector.h>

this has to be hidden - users in the chromium repo don't have WTF/ on their
include path so this won't work.

One option is to have a WebTransformOperationsPrivate that is forward declared
here and held via a WebPrivateOwnPtr and have that class' impl hold a
WTF::Vector

> Source/Platform/chromium/public/WebTransformOperations.h:51
> +    WebTransformationMatrix apply() const;

please add WEBKIT_EXPORT for functions declared here but defined in the .cpp