[webkit-reviews] review granted: [Bug 87301] [chromium] WebLayerTreeViewImpl should not hide methods in CCLayerTreeHost with signatures that match the Client interface : [Attachment 144075] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 87301: [chromium] WebLayerTreeViewImpl should not hide methods in
CCLayerTreeHost with signatures that match the Client interface
https://bugs.webkit.org/show_bug.cgi?id=87301

Attachment 144075: Patch
https://bugs.webkit.org/attachment.cgi?id=144075&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144075&action=review


Looks good.  Not setting cq? since it seems this version doesn't apply cleanly.


> Source/WebKit/chromium/src/WebLayerTreeViewImpl.h:53
> +    OwnPtr<WebLayerTreeViewClientAdapter> m_clientAdapter;
> +    OwnPtr<WebCore::CCLayerTreeHost> m_layerTreeHost;

If you flip the declaration order of these the CCLTH will die before the
clientAdapter without needing any code in the d'tor