[webkit-reviews] review requested: [Bug 82287] MemoryCache should adopt our standard RefCounted model for object lifetime : [Attachment 144086] Add PassCachedResourceHandle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 09:51:20 PDT 2012


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 82287: MemoryCache should adopt our standard RefCounted model for object
lifetime
https://bugs.webkit.org/show_bug.cgi?id=82287

Attachment 144086: Add PassCachedResourceHandle
https://bugs.webkit.org/attachment.cgi?id=144086&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
This patch required some extra shifting around (namely, I moved a bunch of
CachedResourceHandleBase into CachedResourceHandle.cpp because of #include
cycles).

I mostly tried to piggyback off of RefPtr and PassRefPtr, but I don't know this
stuff well enough to be confident that I got it right and avoided refcount
churn.


More information about the webkit-reviews mailing list