[webkit-reviews] review denied: [Bug 73176] Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'. : [Attachment 143726] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dongwoo Joshua Im (dwim)
<dw.im at samsung.com>'s request for review:
Bug 73176: Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
https://bugs.webkit.org/show_bug.cgi?id=73176

Attachment 143726: Patch
https://bugs.webkit.org/attachment.cgi?id=143726&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143726&action=review


If we were to land this patch as written, it would be wrong on
PLATFORM(CHROMIUM).  Instead of breaking other ports, it might make sense to
introduce a new ENABLE macro so that those ports can expose these APIs to the
web when they work.

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:26381
> +		   RelativePath="..\page\CustomHandlersState.cpp"

The indent looks wrong here.  I think this file uses tabs.

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:504
> +    notImplemented();
> +    return "declined";

This gives the wrong answer.