[webkit-reviews] review granted: [Bug 87502] Web Inspector: speed-up HeapSnapshot._bfs method. : [Attachment 144069] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 08:32:15 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 87502: Web Inspector: speed-up HeapSnapshot._bfs method.
https://bugs.webkit.org/show_bug.cgi?id=87502

Attachment 144069: Patch
https://bugs.webkit.org/attachment.cgi?id=144069&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144069&action=review


> Source/WebCore/inspector/front-end/HeapSnapshot.js:934
> +		   nodesToVisit[nodesToVisitLength++] = childNodeIndex;

Please add an assert that nodesToVisitLength <= this.nodeCount


More information about the webkit-reviews mailing list