[webkit-reviews] review requested: [Bug 87301] [chromium] WebLayerTreeViewImpl should not hide methods in CCLayerTreeHost with signatures that match the Client interface : [Attachment 144075] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 25 08:23:56 PDT 2012
Dana Jansens <danakj at chromium.org> has asked for review:
Bug 87301: [chromium] WebLayerTreeViewImpl should not hide methods in
CCLayerTreeHost with signatures that match the Client interface
https://bugs.webkit.org/show_bug.cgi?id=87301
Attachment 144075: Patch
https://bugs.webkit.org/attachment.cgi?id=144075&action=review
------- Additional Comments from Dana Jansens <danakj at chromium.org>
ok! The patch is a little bigger.. but ownership/lifetime issues resolved.
- WebLayerTreeViewImpl owns a CCLayerTreeHost.
- WebLTVI calls CCLTH::create() now so it does not need to call initialize()
itself.
- Moved the ClientAdapter into the WLTVI.cpp
- Expose the CCLTH on WLTVI and call methods on it directly in
WebLayerTreeView.
@jamesr Could you please take another look at this one?
More information about the webkit-reviews
mailing list