[webkit-reviews] review denied: [Bug 80110] [Forms] HTMLFieldSetElement.idl doesn't have elements attribute. : [Attachment 144037] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 25 06:09:07 PDT 2012
Kent Tamura <tkent at chromium.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 80110: [Forms] HTMLFieldSetElement.idl doesn't have elements attribute.
https://bugs.webkit.org/show_bug.cgi?id=80110
Attachment 144037: patch
https://bugs.webkit.org/attachment.cgi?id=144037&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144037&action=review
r- because of test coverage
> LayoutTests/fast/forms/fieldset/fieldset-elements.html:86
> +
Please test:
owner.parentNode.removeChild(owner);
then, adding/removing some form controls to/from 'owner' and owner.elements
is correctly updated.
Also, we need a test to check if changing input type from/to 'image' updates
HTMLFieldSetElement::elements correctly.
More information about the webkit-reviews
mailing list