[webkit-reviews] review granted: [Bug 87490] Web Inspector: drop obsolete WebInspector.Uint32Array and adjust snapshot chunk size for better transfer-snapshot metric : [Attachment 144046] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 05:02:06 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 87490: Web Inspector: drop obsolete WebInspector.Uint32Array and adjust
snapshot chunk size for better transfer-snapshot metric
https://bugs.webkit.org/show_bug.cgi?id=87490

Attachment 144046: Patch
https://bugs.webkit.org/attachment.cgi?id=144046&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144046&action=review


> Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:156
>	       var node_fields_count =
this._snapshot.snapshot.meta.node_fields.length;

node_fields_count -> nodeFieldCount

> Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:157
>	       var nodes_length = this._snapshot.snapshot.node_count *
node_fields_count;

nodes_length -> nodeLength


More information about the webkit-reviews mailing list