[webkit-reviews] review requested: [Bug 80400] [Qt] Set WebCore imagedecoders as default, add fallback to QImageDecoder : [Attachment 144042] proposed patch

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 80400: [Qt] Set WebCore imagedecoders as default, add fallback to
QImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=80400

Attachment 144042: proposed patch
https://bugs.webkit.org/attachment.cgi?id=144042&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
Well... :)

I found another solution to the problem:

- we don't compile jpeg, png, ico (uses png) imagedecoders if we compile on mac
or win
 - in these cases we fallback to QImageDecoder
- every other platform and case uses WebCoreImageDecoder

With this solution we can get rid of QT_IMAGE_DECODER macro, and a lots of
platform specific code from common files.

In ImageDecoder.cpp I used OS(MAC_OS_X) to determine whether the platform is
mac or not, since PLATFORM(MAC) didn't work for me. Do somebody know the reason
for it?

Let's give a shot for the EWSs!