[webkit-reviews] review granted: [Bug 87286] Web Inspector: Speed up edges iteration in heap profiler : [Attachment 143855] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 87286: Web Inspector: Speed up edges iteration in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=87286

Attachment 143855: Patch
https://bugs.webkit.org/attachment.cgi?id=143855&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143855&action=review


>> Source/WebCore/inspector/front-end/HeapSnapshot.js:730
>> +	    this._nodes = new Uint32Array(this._realNodesLength +
this._nodeFieldCount);
> 
> Actually _nodes array has extra elements that were stripped in
WebInspector.Uint32Array.array getter.
> Thus we can avoid additional array reallocation here.

Can we pass an array with nodeLength + nodeFieldCount elements so that we don't
need to allocate new array?