[webkit-reviews] review denied: [Bug 73917] [Qt][WK2] fast/forms/access-key-for-all-elements.html fails : [Attachment 143652] Add shared user agent implementation for Qt. Fixed copyright.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Lauro Moura Maranhao Neto
<lauro.neto at openbossa.org>'s request for review:
Bug 73917: [Qt][WK2] fast/forms/access-key-for-all-elements.html fails
https://bugs.webkit.org/show_bug.cgi?id=73917

Attachment 143652: Add shared user agent implementation for Qt. Fixed
copyright.
https://bugs.webkit.org/attachment.cgi?id=143652&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143652&action=review


> Source/WebCore/platform/qt/UserAgentQt.cpp:29
> +#include <WebCore/SystemInfo.h>

This doesn't look correct... Why did you add the prefix?

> Source/WebCore/platform/qt/UserAgentQt.cpp:31
> +#include <WebKitVersion.h>

This I think is the main issue that's left with this patch/approach and I don't
see a good way around it. It's a layer violation to call WebKit from within
WebCore and in fact it's going to break the force_static_libs_as_shared build.

It doesn't quite feel right to move the WebKit version stuff also into WebCore,
making me think that perhaps we need another static library for code that's
shared between WebKit1 and WebKit2.