[webkit-reviews] review granted: [Bug 85704] Bad checkValidity result on recently "enabled" form fields : [Attachment 143982] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 24 23:16:22 PDT 2012
Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 85704: Bad checkValidity result on recently "enabled" form fields
https://bugs.webkit.org/show_bug.cgi?id=85704
Attachment 143982: Patch
https://bugs.webkit.org/attachment.cgi?id=143982&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143982&action=review
> Source/WebKit/chromium/public/WebInputElement.h:93
> WEBKIT_EXPORT int selectionEnd() const;
> - WEBKIT_EXPORT bool isValidValue(const WebString&) const;
> + WEBKIT_EXPORT bool isValidValue(const WebString&);
> WEBKIT_EXPORT bool isChecked() const;
It's possible that this change breaks Chromium build. Please watch the canary
bots after landing this.
More information about the webkit-reviews
mailing list