[webkit-reviews] review requested: [Bug 74393] [Chromium] Enable grammar checking : [Attachment 143979] Patch v8 (fixed assertion errors)

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 74393: [Chromium] Enable grammar checking
https://bugs.webkit.org/show_bug.cgi?id=74393

Attachment 143979: Patch v8 (fixed assertion errors)
https://bugs.webkit.org/attachment.cgi?id=143979&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,

Unfortunately, my previous change unveiled assertion errors as written in Bug
87390. (I did not notice this "ASSERT(badGrammarLocation == -1)" because I have
not tested my previous change with Debug builds.) I have fixed
EditorClientImpl::checkGrammarOfString() to set badGrammarLocation to -1
instead of 0. (When I tested the latest change with a Debug build on my Win7
box, it finishes without crashes.)

Regards,

Hironori Bono