[webkit-reviews] review denied: [Bug 85704] Bad checkValidity result on recently "enabled" form fields : [Attachment 143975] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 85704: Bad checkValidity result on recently "enabled" form fields
https://bugs.webkit.org/show_bug.cgi?id=85704

Attachment 143975: Patch
https://bugs.webkit.org/attachment.cgi?id=143975&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143975&action=review


> Source/WebCore/html/HTMLFormControlElement.h:98
>  
> -    virtual bool willValidate() const;
> +    virtual bool willValidate();
>      void updateVisibleValidationMessage();

should add OVERRIDE.

> Source/WebCore/html/HTMLFormControlElement.h:162
>  
> -    enum DataListAncestorState { Unknown, InsideDataList, NotInsideDataList
};
> +    enum DataListAncestorState { Unknown, InsideDataList, NotInsideDataList,
DontCare };
>      mutable enum DataListAncestorState m_dataListAncestorState;

This change is unrelated to this bug.

> Source/WebCore/html/HTMLKeygenElement.h:37
> +    virtual bool willValidate() { return false; }

OVERRIDE

> Source/WebCore/html/HTMLOutputElement.h:44
> +    virtual bool willValidate() { return false; }

ditto.