[webkit-reviews] review granted: [Bug 87442] Add feature defines for web-facing parts of CSS Regions and Exclusions : [Attachment 143943] patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <timothy_horton at apple.com>'s request for
review:
Bug 87442: Add feature defines for web-facing parts of CSS Regions and
Exclusions
https://bugs.webkit.org/show_bug.cgi?id=87442

Attachment 143943: patch
https://bugs.webkit.org/attachment.cgi?id=143943&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=143943&action=review


r+ but you need to figure out why this is breaking Windows

> Source/WebCore/ChangeLog:9
> +	   No new tests.

Either explain why there are no new tests, if you think it’s necessary, or just
remove this line. If no tests are listed here, then there are no new tests!

> Source/WebCore/bindings/objc/DOMCSS.mm:55
> +#if ENABLE(CSS_REGIONS)
>  #import "DOMWebKitCSSRegionRule.h"
> +#endif

We don’t stick #if directives into the main #import or #include block. You
should create a separate section with just this #import. This comment applies
to the rest of this patch.