[webkit-reviews] review granted: [Bug 87211] Dodge style recalc when id attribute is overwritten with same value. : [Attachment 143461] Quick hack

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 24 16:41:59 PDT 2012


Eric Seidel <eric at webkit.org> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 87211: Dodge style recalc when id attribute is overwritten with same value.
https://bugs.webkit.org/show_bug.cgi?id=87211

Attachment 143461: Quick hack
https://bugs.webkit.org/attachment.cgi?id=143461&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I would have written this differently.	Probably added a static inline function
to compute the new effective ID, and then done the compare, set and recalc all
in the same if.   But unifying the set's as such could be viewed as a separate
cleanup.


More information about the webkit-reviews mailing list