[webkit-reviews] review granted: [Bug 87436] [chromium] Add a setForceRenderSurface to WebLayer for test/bench purpose : [Attachment 143910] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Antoine Labour
<piman at chromium.org>'s request for review:
Bug 87436: [chromium] Add a setForceRenderSurface to WebLayer for test/bench
purpose
https://bugs.webkit.org/show_bug.cgi?id=87436

Attachment 143910: Patch
https://bugs.webkit.org/attachment.cgi?id=143910&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143910&action=review


Seems good but I'd drop the uncalled getters, personally.

> Source/Platform/chromium/public/WebLayer.h:130
> +    WEBKIT_EXPORT bool forceRenderSurface() const;

Why expose a getter? The caller should know if they've set this or not and if
they care track it (I suspect many won't care).

Compulsively adding getters everywhere makes me feel a bit like writing I'm
writing Java.