[webkit-reviews] review denied: [Bug 86916] garden-o-matic should not fetch from debug bots if it also knows about the release bots : [Attachment 143666] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 86916: garden-o-matic should not fetch from debug bots if it also knows
about the release bots
https://bugs.webkit.org/show_bug.cgi?id=86916

Attachment 143666: Patch
https://bugs.webkit.org/attachment.cgi?id=143666&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143666&action=review


If this doesn't crash in your test case, please add more tests that would
trigger the crash.

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:160
> +	   builders_to_ports = {}

This variable appears to be unused.

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:170
> +	       fallback_path = port.baseline_search_path()

Doesn't this crash?  port is local to the loop above.