[webkit-reviews] review granted: [Bug 87236] [Qt][WK2] Fix failing qmltests::FitToView::test_basic() : [Attachment 143870] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Zalan Bujtas
<zbujtas at gmail.com>'s request for review:
Bug 87236: [Qt][WK2] Fix failing qmltests::FitToView::test_basic()
https://bugs.webkit.org/show_bug.cgi?id=87236

Attachment 143870: Patch
https://bugs.webkit.org/attachment.cgi?id=143870&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143870&action=review


r=me with that change

> Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:-503
> -    m_hadUserInteraction = true;

Please make these asserts instead. The idea is that touchBegin gets called
before panGestureStarted, so lets make sure that never change by making this
into an assert

ASSERT(m_hadUserInteraction); // Set by perceding touchBegin call.

> Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:-567
> -    m_hadUserInteraction = true;

Same here.