[webkit-reviews] review canceled: [Bug 86885] CSS 2.1 failure: border-conflict-element-021a : [Attachment 143781] Patch

Thu May 24 13:55:39 PDT 2012

Julien Chaffraix <jchaffraix at webkit.org> has canceled Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 86885: CSS 2.1 failure: border-conflict-element-021a
https://bugs.webkit.org/show_bug.cgi?id=86885

Attachment 143781: Patch
https://bugs.webkit.org/attachment.cgi?id=143781&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143781&action=review

Nice change, some comments.

> Source/WebCore/rendering/RenderTable.cpp:595
> +	       for (RenderObject* child = lastChild(); child; child =
child->previousSibling())

While this change is good, I would really love for us to iterate directly over
RenderTableSection here. You would need to add the following function though:

RenderTableSection* lastSection() const;

and the iterate using sectionAbove().

> LayoutTests/fast/table/border-collapsing/adjacent-row-groups-expected.html:2
> +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">

Please, let's use the HTML5 doctype:

<!DOCTYPE html>

> LayoutTests/fast/table/border-collapsing/adjacent-row-groups-expected.html:7
> +<title>Bugzilla Bug: 86885. CSS Test: Border conflict resolution - adjacent
table row groups with same border-style and border-width. Expected
result.</title>

Just remove the title (see below why).

> LayoutTests/fast/table/border-collapsing/adjacent-row-groups-expected.html:20

> +<p>When two adjacent table row groups (thead, tbody, tfoot) have the same
border-width and the same border-style in a 'border-collapse: collapse' table,
then the color of the border from the topmost table row group wins: so, a thead
wins over a tbody which wins over tfoot.</p>
> +  

The long explanation is nice but the following more basic information are
useful and should also be present (in the output as this is a ref-test, not in
a non-dumped <title> tag):
* bug id, bonus point for having a clickable form.
* bug title
* what are the condition for the test to pass.

> LayoutTests/fast/table/border-collapsing/adjacent-row-groups-expected.html:23

> +
> +    

Please remove those unneeded empty lines (not repeated).

Also let's add the missing section.

> LayoutTests/fast/table/border-collapsing/adjacent-row-groups-expected.html:25

> +	       <td class="t1">  </td>

Nit: You don't strictly need any text here and could just specify the size of
your cells in CSS:

td {
   width: 100px;
   height: 100px;
}

(text has several issues in test cases that makes me avoid it as much as I can)

> LayoutTests/fast/table/border-collapsing/adjacent-row-groups.html:16
> +    thead {border-color: blue;}
> +    tbody {border-color: yellow;}
> +    tfoot {border-color: orange;}

A good reading on test case is the trac page about that:
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree#Gen
eraltips

I usually prefer a red / green test: everything that shouldn't be shown should
be red and everything that should be shown should be green. Here it would give
the following rules:

thead, tbody, tfoot {
    border: 1px solid green;
    border-top: 1px solid red;
}
thead {
    border-top: 1px solid green;
}