[webkit-reviews] review granted: [Bug 86995] Cleanup: add a file system call which captures the file metadata at once. : [Attachment 143768] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 86995: Cleanup: add a file system call which captures the file metadata at
once.
https://bugs.webkit.org/show_bug.cgi?id=86995

Attachment 143768: Patch
https://bugs.webkit.org/attachment.cgi?id=143768&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143768&action=review


Only two comments. Feel free to address and submit.

> Source/WebCore/platform/FileMetadata.h:57
> +#endif // ENABLE(FILE_SYSTEM)

The end comment for the if isn't necessary and doesn't seem very useful for
such a short area.

> Source/WebCore/platform/chromium/FileSystemChromium.cpp:61
> +bool getFileMetadata(const String& path, FileMetadata& result)

result isn't very descriptive.

> Source/WebCore/platform/chromium/FileSystemChromium.cpp:70
> +    result.modificationTime = modificationTime;

Why doesn't this set type?