[webkit-reviews] review granted: [Bug 87286] Web Inspector: Speed up edges iteration in heap profiler : [Attachment 143604] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 87286: Web Inspector: Speed up edges iteration in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=87286

Attachment 143604: Patch
https://bugs.webkit.org/attachment.cgi?id=143604&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143604&action=review


> Source/WebCore/ChangeLog:3
> +	   Web Inspector: Speed up edges iteration in heap profiler

Does it have any noticeable impact on the performance? Please attach
measurement results for the heap profiler perf test.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:724
> +	   this._nodesLength = this._nodes.length;

_nodesLength name is confusing because _nodes.length is actually different, you
can use this.nodeCount * this._nodeFieldCount for nodesLength where necessary
or pick a better name that would reflect the difference with this._nodes.length