[webkit-reviews] review granted: [Bug 87371] RadioNodeList does not include a object element : [Attachment 143816] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 24 07:37:23 PDT 2012


Kent Tamura <tkent at chromium.org> has granted Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 87371: RadioNodeList does not include a object element
https://bugs.webkit.org/show_bug.cgi?id=87371

Attachment 143816: patch
https://bugs.webkit.org/attachment.cgi?id=143816&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143816&action=review


> Source/WebCore/html/RadioNodeList.cpp:93
> +    if (testElement->hasTagName(objectTag))
> +	   return checkIfNameOrIdMatches(testElement);

Would you add an assertion that
  ASSERT(m_formElement ==
static_cast<HTMLObjectElement*>(testElement)->form());

please?


More information about the webkit-reviews mailing list