[webkit-reviews] review denied: [Bug 87377] Web Inspector: [regression] search in formatted scripts is broken. : [Attachment 143800] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 24 07:31:44 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 87377: Web Inspector: [regression] search in formatted scripts is broken.
https://bugs.webkit.org/show_bug.cgi?id=87377

Attachment 143800: Patch
https://bugs.webkit.org/attachment.cgi?id=143800&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143800&action=review


> Source/WebCore/inspector/front-end/JavaScriptSource.js:196
> +	   this.requestContent(callbackWrapper.bind(this));

You should not requestContent for all scripts, we have searchInContent
implemented on backend.


More information about the webkit-reviews mailing list