[webkit-reviews] review granted: [Bug 87382] Web Inspector: convert HeapSnapshotGridNode._provider into getter. : [Attachment 143809] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 87382: Web Inspector: convert HeapSnapshotGridNode._provider into getter.
https://bugs.webkit.org/show_bug.cgi?id=87382

Attachment 143809: Patch
https://bugs.webkit.org/attachment.cgi?id=143809&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143809&action=review


> Source/WebCore/bindings/v8/ScriptHeapSnapshot.cpp:71
> +    int GetChunkSize() { return 102400; }

Please revert this.

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:54
> +	* @return
{WebInspector.HeapSnapshotProviderProxy|WebInspector.HeapSnapshotDiffNodesProvi
der}

WebInspector.HeapSnapshotDiffNodesProvider now extends
WebInspector.HeapSnapshotProviderProxy so the annotation can be simplified.

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:56
> +    _createProvider: function()

This should be public as it is overridden in the descendants.

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:61
> +    get _provider()

Can you used provider() function instead of a getter?