[webkit-reviews] review granted: [Bug 87236] [Qt][WK2] Fix failing qmltests::FitToView::test_basic() : [Attachment 143792] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Zalan Bujtas
<zbujtas at gmail.com>'s request for review:
Bug 87236: [Qt][WK2] Fix failing qmltests::FitToView::test_basic()
https://bugs.webkit.org/show_bug.cgi?id=87236

Attachment 143792: Patch
https://bugs.webkit.org/attachment.cgi?id=143792&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143792&action=review


r=me with the changes

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:127
> -    emit d->viewportItem->experimental()->test()->contentsScaleCommitted();
> +    emit d->viewportItem->experimental()->test()->contentsScaleChanged();

unrelated, should be part of another patch

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:930
> -	       // Emits contentsScaleCommitted();
> +	       // Emits contentsScaleChanged();

Other patch?