[webkit-reviews] review granted: [Bug 87342] Elements in Shadow DOM is not resizable. : [Attachment 143733] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 87342: Elements in Shadow DOM is not resizable.
https://bugs.webkit.org/show_bug.cgi?id=87342

Attachment 143733: Patch
https://bugs.webkit.org/attachment.cgi?id=143733&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143733&action=review


> Source/WebCore/ChangeLog:3
> +	   Elements in Shadow DOM is not resizable.

Nit: ARE not resizable.

> Source/WebCore/rendering/RenderLayer.cpp:1858
> +    Element* element = static_cast<Element*>(renderer()->node());

Don't we have toElement? We should at least assert that node() is Element*.

> LayoutTests/ChangeLog:3
> +	   Elements in Shadow DOM is not resizable.

Ditto: are.

> LayoutTests/fast/dom/shadow/resize-in-shadow-dom.html:6
> +<script src="resources/polyfill.js"></script>
> +<script src="../resources/event-sender-util.js"></script>
> +<script src="../../js/resources/js-test-pre.js"></script>

You can put all of this in the body instead.

> LayoutTests/fast/dom/shadow/resize-in-shadow-dom.html:40
> +var element = document.elementFromPoint(x, y);

Why do we need this statement here?