[webkit-reviews] review granted: [Bug 87322] improve StyleRareNonInheritedData bit packing on Windows : [Attachment 143678] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 23 17:16:29 PDT 2012
Eric Seidel <eric at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 87322: improve StyleRareNonInheritedData bit packing on Windows
https://bugs.webkit.org/show_bug.cgi?id=87322
Attachment 143678: Patch
https://bugs.webkit.org/attachment.cgi?id=143678&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143678&action=review
LGTM.
> Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:150
> bool StyleRareNonInheritedData::operator==(const StyleRareNonInheritedData&
o) const
Presumably we could optimize the comparison order. Do you believe that was
attempted previously? I'm OK with this kept in this order if you think it's
unlikely to matter for perf.
More information about the webkit-reviews
mailing list