[webkit-reviews] review denied: [Bug 86913] auto margins on flexbox should allocate space in the cross direction : [Attachment 143647] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Tony Chang <tony at chromium.org>'s
request for review:
Bug 86913: auto margins on flexbox should allocate space in the cross direction
https://bugs.webkit.org/show_bug.cgi?id=86913

Attachment 143647: Patch
https://bugs.webkit.org/attachment.cgi?id=143647&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143647&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:720
> +	   child->setMarginTop(availableAlignmentSpace / 2);
> +	   child->setMarginBottom(availableAlignmentSpace / 2);
> +	   return true;
> +    }
> +    if (start.isAuto()) {
> +	   adjustAlignmentForChild(child, availableAlignmentSpace);
> +	   child->setMarginTop(availableAlignmentSpace);
> +	   return true;
> +    }
> +    if (end.isAuto()) {
> +	   child->setMarginBottom(availableAlignmentSpace);

If we're in a vertical flow, don't we want to be setting
marginLeft/marginRight?