[webkit-reviews] review denied: [Bug 87245] [EFL] Ewk_Intent does not expose WebCore::Intent::data() : [Attachment 143528] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 87245: [EFL] Ewk_Intent does not expose WebCore::Intent::data()
https://bugs.webkit.org/show_bug.cgi?id=87245

Attachment 143528: Patch
https://bugs.webkit.org/attachment.cgi?id=143528&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143528&action=review


>> Source/WebCore/bindings/js/SerializedScriptValue.cpp:1791
>> +	characters.append(data.characters8(), data.length());
> 
> Do you need to check data.is8bit() here and create an intermediate
representation if it isn't? Or should wire format strings always be 8-bit?

This isn't right.  You should create a CString temporary using data.utf8() and
then use the accessors on the CString to get the chars out.