[webkit-reviews] review granted: [Bug 83928] [chromium] add instrumentation for compositing : [Attachment 143612] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 83928: [chromium] add instrumentation for compositing
https://bugs.webkit.org/show_bug.cgi?id=83928

Attachment 143612: Patch
https://bugs.webkit.org/attachment.cgi?id=143612&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143612&action=review


Looks good but be careful when landing not to compile-bust chromium.  Safest is
to land the chromium implementations of the new functions first, I think.

> Source/Platform/chromium/public/WebLayerTreeViewClient.h:44
> +    // Indicates that main thread tasks associated with frame rendering have
completed.
> +    // Issued unconditionally, even if the context was lost in the process.
> +    virtual void didBeginFrame() = 0;

There are implementations of WebLayerTreeViewClient outside the WebKit
repository (like ui/compositor/compositor.h in chromium), so adding a new pure
virtual means you have to land the chromium-side impls first or add some #ifdef
guards

nit: newline between the previous function and this comment block, please

>> Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:28
>> +#include <gmock/gmock.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Just bulk select this whole #include block and run sort on it

>> Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:30
>> +#include "platform/WebLayer.h"
> 
> Found header this file implements after other header. Should be: config.h,
primary header, blank line, and then alphabetically sorted. 
[build/include_order] [4]

Here the stylebot is just wrong. a sort of the whole block is right.

> Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:33
> +#include "platform/WebLayerTreeView.h"
> +#include "platform/WebLayerTreeViewClient.h"
> +#include "platform/WebThread.h"

nit: include this as <public/Web*.h>, please