[webkit-reviews] review granted: [Bug 86191] Mac DRT should be able to load external URLs for replay performance tests : [Attachment 143603] More fixes per Alexey's comment
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 23 12:23:19 PDT 2012
Alexey Proskuryakov <ap at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 86191: Mac DRT should be able to load external URLs for replay performance
tests
https://bugs.webkit.org/show_bug.cgi?id=86191
Attachment 143603: More fixes per Alexey's comment
https://bugs.webkit.org/attachment.cgi?id=143603&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143603&action=review
> Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm:132
> + // FIXME: Support IPv6 loopbacks
Nit: period at the end of sentence.
> Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm:165
> + NSString *lowercaseTestURL = [testPathOrURL lowercaseString];
Should this be lowercaseTestPathOrURL, too?
More information about the webkit-reviews
mailing list