[webkit-reviews] review granted: [Bug 87165] Crash in fast/files/read tests during Garbage Collection : [Attachment 143361] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 23 12:17:48 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 87165: Crash in fast/files/read tests during Garbage Collection
https://bugs.webkit.org/show_bug.cgi?id=87165

Attachment 143361: Patch
https://bugs.webkit.org/attachment.cgi?id=143361&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Discussed this in person. The issue is that garbage collection can happen after
state is set to DONE before window.event.target chain is fully established.

Also, the suggested design is similar to what XMLHttpRequest does, which is
good for consistency.

r=me, but please add comments explaining why unsetPendingActivity are in the
places they are in.


More information about the webkit-reviews mailing list