[webkit-reviews] review granted: [Bug 15494] SVGZoomAndPan constants are missing from window object : [Attachment 143499] Patch v7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 23 10:03:39 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 15494: SVGZoomAndPan constants are missing from window object
https://bugs.webkit.org/show_bug.cgi?id=15494

Attachment 143499: Patch v7
https://bugs.webkit.org/attachment.cgi?id=143499&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143499&action=review


Looks good! A welcome cleanup.

> Source/WebCore/ChangeLog:20
> +	   MSVC can't decide wheteher it should call toJS(Node*) or
toJS(SVGZoomAndPan*) for a SVGSVGElement.

Typo: whether.

> Source/WebCore/ChangeLog:26
> +

Maybe reference the test section here, why you do not need to add new tests.


More information about the webkit-reviews mailing list