[webkit-reviews] review denied: [Bug 86847] Web Inspector: Support hierarchical context menus : [Attachment 143538] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 86847: Web Inspector: Support hierarchical context menus
https://bugs.webkit.org/show_bug.cgi?id=86847

Attachment 143538: Patch
https://bugs.webkit.org/attachment.cgi?id=143538&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143538&action=review


Make sure you implement SoftContextMenu based on the new descriptor.

> Source/WebCore/inspector/front-end/ContextMenu.js:45
> +    this._topLevelMenu = topLevelMenu;

this._contextMenu

> Source/WebCore/inspector/front-end/ContextMenu.js:51
> +    get id()

id: function()

> Source/WebCore/inspector/front-end/ContextMenu.js:56
> +    get type()

type: function()

> Source/WebCore/inspector/front-end/ContextMenu.js:95
> +	   this._topLevelMenu.setHandler(item.id, handler);

Make it all private.

> Source/WebCore/inspector/front-end/ContextMenu.js:143
> +    toProtocol: function()

_buildDescriptor: