[webkit-reviews] review granted: [Bug 87257] [Qt] Buildfix for newer Qt5 : [Attachment 143559] proposed buildfix

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 87257: [Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=87257

Attachment 143559: proposed buildfix
https://bugs.webkit.org/attachment.cgi?id=143559&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143559&action=review


> Source/WebKit/qt/declarative/plugin.cpp:47
> +#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))

I'm surprised this works with the moc......

> Source/WebKit/qt/declarative/plugin.cpp:51
> +class WebKitQmlPlugin : public QQmlExtensionPlugin {
> +#else
>  class WebKitQmlPlugin : public QDeclarativeExtensionPlugin {
> +#endif

If this works, then it's okay for now. I'll try to split up the plugin into a
proper QtQuick1 based plugin that exports QDeclarativeWebView and one that
exports the QML2 components.