[webkit-reviews] review denied: [Bug 85863] [Shadow] Style elements in Shadow DOM should not be exposed by document.styleSheets attribute : [Attachment 143440] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 85863: [Shadow] Style elements in Shadow DOM should not be exposed by
document.styleSheets attribute
https://bugs.webkit.org/show_bug.cgi?id=85863

Attachment 143440: Patch
https://bugs.webkit.org/attachment.cgi?id=143440&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
While I'm no shadow DOM expert, I feel that this patch needs more explanation
of what's going on.

Why are we skipping over
StyleElement::insertedIntoDocument/removedFromDocument? That will not only
prevent document.styleSheets from exposing the sheet, but also prevent
StyleElement from parsing the sheet, and StyleResolver from applying any of its
style (since it gets its sheet data from there.)

Maybe <style> elements are supposed to just hang dead inside a shadow subtree?