[webkit-reviews] review requested: [Bug 87161] DFG CSE should do redundant store elimination : [Attachment 143470] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 23:13:30 PDT 2012


Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 87161: DFG CSE should do redundant store elimination
https://bugs.webkit.org/show_bug.cgi?id=87161

Attachment 143470: the patch
https://bugs.webkit.org/attachment.cgi?id=143470&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Includes two fixes for handling implicit loads of local variables:

GetScopeChain reads the activation register. Hence, removing a SetLocal to the
activation register that is live at the GetScopeChain is wrong.

There are other cases of implicit loads of locals, but they are already marked
as either exiting or clobbering, so they are already handled correctly.


More information about the webkit-reviews mailing list