[webkit-reviews] review granted: [Bug 87214] Short-circuit Element::attrIfExists() when the Element has no Attr list. : [Attachment 143463] A patchwork orange

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 22:35:04 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 87214: Short-circuit Element::attrIfExists() when the Element has no Attr
list.
https://bugs.webkit.org/show_bug.cgi?id=87214

Attachment 143463: A patchwork orange
https://bugs.webkit.org/attachment.cgi?id=143463&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143463&action=review


> Source/WebCore/dom/Element.cpp:2087
> +    if (!hasAttrList())
> +	   return 0;
>      if (!attributeData())
>	   return 0;

Should we combine these if statements?


More information about the webkit-reviews mailing list